Update ExpenditureAccountRepositoryJPA and RevenueAccountRepositoryJPA to use natural id queries for getByCode

Description

The ExpenditureAccountRepositoryJPA.getByCode and RevenueAccountRepositoryJPA.getByCode methods could both use get by natural id queries which would be more efficient. This would be similar to how CashAccountRepositoryJPA does its getByCode query. Update these repositories to perform natural id queries using this method.

Environment

None

Activity

Show:

Dave Smith February 19, 2019 at 4:54 PM

approved for 120 payment.

Kyle Miller February 16, 2019 at 5:09 PM

For unexplained reasons the changes to the ExpenditureAccountRepositoryJPA caused the SOAP test failures in TestUSASWSRequisition testPostUpdatedRequisition so the change was reverted.

Kyle Miller February 14, 2019 at 4:41 PM

SOAP tests need fixed

Kyle Miller February 13, 2019 at 12:58 AM

Looked for all getByCode repositories and found AnticipatedRevenueRepositoryJPA so I implemented the naturalId to its getByCode method as well.

Robin Fronk July 20, 2018 at 6:41 PM

Changes caused SOAP QA test to fail. Need to investigate the reason for test failure.

Fixed

Details

Assignee

Reporter

Story Points

Fix versions

Times Requested

1

Source

120 Eligible

Yes

Time tracking

4h 30m logged

Components

Sprint

Affects versions

Priority

Better PDF Exporter

Created January 8, 2018 at 6:11 PM
Updated February 28, 2019 at 2:17 PM
Resolved February 28, 2019 at 2:17 PM